[clang][bytecode] Allocate InitMaps via Program/InterpState allocators #170272
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Save them as a pointer intead of using a shared_ptr. This we we can use the pointer integer value to differentiate the "no initmap yet" and "all values initialzed" cases. This regresses one test case in const-eval.c, but as it turns out, that only worked coincidentally before.
tbaederr
added
clang:frontend
Contributor
|
Hi @tbaederr |
tbaederr
added a commit
that referenced
this pull request
Dec 9, 2025
…llocators (#170272)" This reverts commit 8fe38c4. This breaks the clang-armv7-2stage build bot: https://lab.llvm.org/buildbot/#/builders/79/builds/2531
Contributor
Author
|
Damn. I've reverted it for now via 773a6a9 |
honeygoyal
pushed a commit
to honeygoyal/llvm-project
that referenced
this pull request
Dec 9, 2025
llvm#170272) Save them as a pointer intead of using a shared_ptr. This we we can use the pointer integer value to differentiate the "no initmap yet" and "all values initialzed" cases. This regresses one test case in const-eval.c, but as it turns out, that only worked coincidentally before.
honeygoyal
pushed a commit
to honeygoyal/llvm-project
that referenced
this pull request
Dec 9, 2025
…llocators (llvm#170272)" This reverts commit 8fe38c4. This breaks the clang-armv7-2stage build bot: https://lab.llvm.org/buildbot/#/builders/79/builds/2531
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Save them as a pointer intead of using a shared_ptr. This we we can use the pointer integer value to differentiate the "no initmap yet" and "all values initialzed" cases.
This regresses one test case in const-eval.c, but as it turns out, that only worked coincidentally before.